[llvm-commits] [PATCH] CrashRecoveryContext.cpp Win32 support

Aaron Ballman aaron at aaronballman.com
Mon Aug 15 05:16:49 PDT 2011


On Mon, Aug 15, 2011 at 4:49 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Aaron and Anton,
>
> Aaron's patch is good at functionality but a little redundant due to
> considering w2k.
>
> Anton, I propose it would be the time for us to abandon Windows 2000
> to coming llvm 3.0.
> It was 20th Century System :D
> How do you think?
>
> Aaron, do you think your patch would be simpler if we could get rid of w2k?
> (oc, I think so)

I was unsure of how far back we wanted support to extend, which is why
I lazy-loaded the code.  If we're going to support XP and higher, the
code would be cleaner.

I'll make the modifications tonight and resubmit.

Thanks for the review!

~Aaron



More information about the llvm-commits mailing list