[llvm-commits] [poolalloc] r137561 - /poolalloc/trunk/include/poolalloc/Heuristic.h

Will Dietz wdietz2 at illinois.edu
Sat Aug 13 12:06:30 PDT 2011


Author: wdietz2
Date: Sat Aug 13 14:06:30 2011
New Revision: 137561

URL: http://llvm.org/viewvc/llvm-project?rev=137561&view=rev
Log:
Requiring yourself transitively makes PassManager very unhappy, don't this this!

(This probably didn't crop up earlier since addRequiredTransitive wasn't
 actually implemented until Jan 2011, r123942)

Modified:
    poolalloc/trunk/include/poolalloc/Heuristic.h

Modified: poolalloc/trunk/include/poolalloc/Heuristic.h
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/include/poolalloc/Heuristic.h?rev=137561&r1=137560&r2=137561&view=diff
==============================================================================
--- poolalloc/trunk/include/poolalloc/Heuristic.h (original)
+++ poolalloc/trunk/include/poolalloc/Heuristic.h Sat Aug 13 14:06:30 2011
@@ -171,10 +171,6 @@
         // We require DSA while this pass is still responding to queries
         AU.addRequiredTransitive<EQTDDataStructures>();
 
-        // Make PassManager happy be requiring the default implementation of
-        // this analysis group
-        AU.addRequiredTransitive<Heuristic>();
-
         // This pass does not modify anything when it runs
         AU.setPreservesAll();
       }
@@ -219,10 +215,6 @@
         // We require DSA while this pass is still responding to queries
         AU.addRequiredTransitive<EQTDDataStructures>();
 
-        // Make PassManager happy be requiring the default implementation of
-        // this analysis group
-        AU.addRequiredTransitive<Heuristic>();
-
         // This pass does not modify anything when it runs
         AU.setPreservesAll();
       }
@@ -254,10 +246,6 @@
         // We require DSA while this pass is still responding to queries
         AU.addRequiredTransitive<EQTDDataStructures>();
 
-        // Make PassManager happy be requiring the default implementation of
-        // this analysis group
-        AU.addRequiredTransitive<Heuristic>();
-
         // This pass does not modify anything when it runs
         AU.setPreservesAll();
       }
@@ -289,10 +277,6 @@
         // We require DSA while this pass is still responding to queries
         AU.addRequiredTransitive<EQTDDataStructures>();
 
-        // Make PassManager happy be requiring the default implementation of
-        // this analysis group
-        AU.addRequiredTransitive<Heuristic>();
-
         // This pass does not modify anything when it runs
         AU.setPreservesAll();
       }
@@ -331,10 +315,6 @@
         // We require DSA while this pass is still responding to queries
         AU.addRequiredTransitive<EQTDDataStructures>();
 
-        // Make PassManager happy be requiring the default implementation of
-        // this analysis group
-        AU.addRequiredTransitive<Heuristic>();
-
         // This pass does not modify anything when it runs
         AU.setPreservesAll();
       }
@@ -367,10 +347,6 @@
         // We require DSA while this pass is still responding to queries
         AU.addRequiredTransitive<EQTDDataStructures>();
 
-        // Make PassManager happy be requiring the default implementation of
-        // this analysis group
-        AU.addRequiredTransitive<Heuristic>();
-
         // This pass does not modify anything when it runs
         AU.setPreservesAll();
       }





More information about the llvm-commits mailing list