[llvm-commits] [llvm] r137170 - in /llvm/trunk: docs/Atomics.html docs/LangRef.html include/llvm/Bitcode/LLVMBitCodes.h include/llvm/Instructions.h lib/AsmParser/LLParser.cpp lib/AsmParser/LLParser.h lib/Bitcode/Reader/BitcodeReader.cpp lib/Bitcode/Writer/BitcodeWriter.cpp lib/Transforms/Scalar/LowerAtomic.cpp lib/VMCore/AsmWriter.cpp lib/VMCore/Instructions.cpp lib/VMCore/Verifier.cpp
Chris Lattner
clattner at apple.com
Thu Aug 11 13:11:15 PDT 2011
On Aug 9, 2011, at 4:02 PM, Eli Friedman wrote:
> Author: efriedma
> Date: Tue Aug 9 18:02:53 2011
> New Revision: 137170
>
> URL: http://llvm.org/viewvc/llvm-project?rev=137170&view=rev
> Log:
> Representation of 'atomic load' and 'atomic store' in IR.
>
Looks good, two requests:
1. Needs testcase :)
2. Please take the atomic keyword *after* load/store instead of before it. I know that this is consistent with volatile, but volatile itself is a bug. We'd prefer to have "load volatile atomic i32* ..." rather than "volatile atomic load i32*".
Somewhere on my todo list is to make the asmprinter and asmparser accept volatile after load/store, but it isn't likely to happen in the near future.
-Chris
More information about the llvm-commits
mailing list