[llvm-commits] [llvm] r137303 - in /llvm/trunk: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp test/CodeGen/X86/fast-isel-gep.ll

[Peter Collingbourne]

On Thu, Aug 11, 2011 at 06:26:54AM -0000, Chris Lattner wrote:
> Author: lattner
> Date: Thu Aug 11 01:26:54 2011
> New Revision: 137303
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=137303&view=rev
> Log:
> fix PR10605 / rdar://9930964 by adding a pretty scary missed check.

Thanks!

> --- llvm/trunk/test/CodeGen/X86/fast-isel-gep.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/fast-isel-gep.ll Thu Aug 11 01:26:54 2011
> @@ -107,3 +107,30 @@
>    unreachable
>  }
>  declare i8* @_ZNK18G__FastAllocString4dataEv() nounwind
> +
> +
> +; PR10605 / rdar://9930964 - Don't fold loads incorrectly.  The load should
> +; happen before the store.  
> +define i32 @test7({i32,i32,i32}* %tmp1, i32 %tmp71, i32 %tmp63) nounwind  {
> +; X64: test7:
> +; X64:    movl	8({{%rdi|%rcx}}), %eax
> +; X64     movl	$4, 8({{%rdi|%rcx}})

Shouldn't there be a colon on this line here?

Thanks,
-- 
Peter