[llvm-commits] X86 FastISel: Emit immediate call arguments locally to save stack size when compiling with -O0

[Jakob Stoklund Olesen]

On Aug 10, 2011, at 4:01 PM, Ivan Krasin wrote:

> Hi Jacob,
> 
> here is the new version of the patch. Now, the local cache does not
> cross the function call (with the exception of intrinsics, since they
> tend to be inlined).
> I have found it hard to emit definition at last use w/o slowing down
> -O0 build (which is inapropriate). Please, find the patch attached.

Eric, could you take a look at this patch when you have the time, please?

> I have also ran my small benchmark tool over test-suite bitcode files.
> The full log is attached to the e-mail, below are some excerpts.
> first toolchain is the toolchain with the patch
> second toolchain is the unmodified llvm toolchain.
> 
> The command line I used to run llc:
> Release/bin/llc -O0 -stats --time-passes -relocation-model=pic -O0
> -asm-verbose=false

What architecture did you test?

> stdin/stdout/stderr were redirected to my tester. Every test has been
> ran once, so Seconds and WallSeconds could slightly differ if I ran
> the tool again.

I'd rather not look through 700 K of raw data. Please provide a summary, including the worst regressions.

/jakob