[llvm-commits] [llvm] r137190 - in /llvm/trunk: include/llvm/Analysis/LoopInfo.h lib/Transforms/Utils/LoopUnroll.cpp test/Transforms/LoopUnroll/2011-08-08-PhiUpdate.ll test/Transforms/LoopUnroll/2011-08-09-PhiUpdate.ll

[Andrew Trick]

On Aug 9, 2011, at 5:43 PM, Eli Friedman wrote:

> On Tue, Aug 9, 2011 at 5:28 PM, Andrew Trick <atrick at apple.com> wrote:
>> Author: atrick
>> Date: Tue Aug  9 19:28:10 2011
>> New Revision: 137190
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=137190&view=rev
>> Log:
>> Fix the LoopUnroller to handle nontrivial loops and partial unrolling.
>> 
>> These are not individual bug fixes. I had to rewrite a good chunk of
>> the unroller to make it sane. I think it was getting lucky on trivial
>> completely unrolled loops with no early exits. I included some fairly
>> simple unit tests for partial unrolling. I didn't do much stress
>> testing, so it may not be perfect, but should be usable now.
> 
> Does this address http://llvm.org/bugs/show_bug.cgi?id=2253 and/or
> http://llvm.org/bugs/show_bug.cgi?id=7318 ?
> 
> -Eli

Yes and Yes. Closing them soon. Just making sure I don't have to revert.

-Andy