[llvm-commits] [llvm] r137111 - /llvm/trunk/lib/Support/Unix/Host.inc

[Chris Lattner]

On Aug 9, 2011, at 12:35 PM, Bob Wilson wrote:

>>> Recognize the UNAME_RELEASE environment variable to match Darwin's uname.
>>> When this variable is set, "uname -r" will return its value instead of the
>>> real OS version.  Make this affect LLVM's triple for consistency.
>>> <rdar://problem/9919167>
>> 
>> Hi Bob,
>> 
>> Should this be #ifdef __APPLE__ or something?
>> 
>> -Chris
> 
> I thought about that but decided that since no one else is likely to set UNAME_RELEASE that it wasn't necessary.  I'll take your question as a hint that you would prefer it with the #ifdef.

Yep, calling getenv isn't free.  Only those who get the benefit should pay the cost.

-Chris