[llvm-commits] [patch][arm] Implement support for the Q, R and H modifiers

[Jakob Stoklund Olesen]

On Aug 8, 2011, at 9:38 AM, Rafael Ávila de Espíndola wrote:

> 
>> You are missing some error handling. You are accessing OpNum+1
>> without checking that it is part of the current asm operand.
> 
> The attached patch adds "RegOp >= MI->getNumOperands()" check. Is there a more specific check for asm operands?

Yes, each group of machine operands on an INLINEASM begin with an immediate describing the group.

In this case, it is probably good enough to check that OpNum+1 exists and is a register.

/jakob