[llvm-commits] [patch][arm] Implement support for the Q, R and H modifiers

[Jakob Stoklund Olesen]

On Aug 8, 2011, at 8:28 AM, Rafael Ávila de Espíndola wrote:

>>> This assumes the operand is the low register of the pair, i.e. even. Is that guaranteed?
>> 
>> No.
>> 
>> We don't allocate even/odd pairs for 64-bit values. We don't even allocate consecutive registers.
>> 
>> Without that constraint, I can't imagine a use for the 'H' modifier?
> 
> True. I only tested with function arguments, so I missed this. Thanks for catching it.
> 
> The attached patch handles only the R and Q constraints. Is it OK?

You are missing some error handling. You are accessing OpNum+1 without checking that it is part of the current asm operand.

/jakob