[llvm-commits] [PATCH] Add Pattern ID Information

[Chris Lattner]

On Aug 5, 2011, at 4:42 PM, Jakob Stoklund Olesen wrote:

> 
> On Aug 5, 2011, at 4:28 PM, Villmow, Micah wrote:
> 
>>> You would be better off using an immediate operand to encode your extra
>>> semantics.
>> [Villmow, Micah] That is not really feasible to add an extra operand to 
>> hundreds of instructions when there is already a location that store the
>> 15 bits of information that is needed(8 in flags, 7 in AsmPrinterFlags). 
> 
> You are of course free to do whatever you want in your own tree. I am simply trying to steer you in a direction that will cause you less grief when merging with trunk.

Also, your argument is basically "we are knowingly do something that is documented as a bad idea, because it is easier than fixing our code to do the right thing".  I'm not going to do it, but this makes me want to go rip out asmprinter flags - it doesn't make me inclined to extend them.

-Chris