[llvm-commits] [PATCH] Add Pattern ID Information

[David A. Greene]

Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

> I could perhaps see the utility of a general mechanism for annotating
> machine instructions, but as you say, this patch doesn't bring us any
> closer to that. It is one more ad-hoc thing on top of the existing
> AsmPrinterFlags.

The problem is that a general annotation needs something like a string
and no one wants to add strings to SDNodes, MachineInstrs, etc.

> We added AsmPrinterFlags almost two years ago. In that time, nobody
> has defined more flags, and the existing ReloadReuse flag is only
> written by VirtRegRewriter.cpp which isn't even in the default
> pipeline any more.

We use other flags here but they probably aren't interesting for others.

> I simply don't think this is useful to anyone else.

I would disagree with that statement but I'm not going to push something
in people don't want.  I'll just keep the changes here.  If LLVM makes
the move to git perhaps we can publish a public git tree containing
these changes and people can pull from it if they want.

                                   -Dave