[llvm-commits] [PATCH]Fix a typo in X86ISelLowering.cpp

[Duncan Sands]

Hi Cameron,

On 04/08/11 11:58, Cameron Zwarich wrote:
> Can you write a test case?

while a testcase would be good the patch does seem obviously correct.

Ciao, Duncan.

>
> Cameron
>
> ב-4 באוג 2011, בשעה 02:44, Ivan Krasin<krasin at chromium.org>  כתב/ה:
>
>> Hi llvm team,
>>
>> this patch fixes a typo in lib/Target/X86/X86ISelLowering.cpp. The
>> credits go to http://habrahabr.ru/blogs/compilers/125626/ (Russian
>> hacker news)
>>
>> Ivan
>>
>> Index: lib/Target/X86/X86ISelLowering.cpp
>> ===================================================================
>> --- lib/Target/X86/X86ISelLowering.cpp    (revision 136864)
>> +++ lib/Target/X86/X86ISelLowering.cpp    (working copy)
>> @@ -11686,7 +11686,7 @@
>>          // Converting this to a max would handle comparisons between positive
>>          // and negative zero incorrectly.
>>          if (!UnsafeFPMath&&
>> -            !DAG.isKnownNeverZero(LHS)&&  !DAG.isKnownNeverZero(LHS))
>> +            !DAG.isKnownNeverZero(LHS)&&  !DAG.isKnownNeverZero(RHS))
>>            break;
>>          Opcode = X86ISD::FMAX;
>>          break;
>> <lhs-rhs-typo.patch>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits