[llvm-commits] [llvm] r136751 - /llvm/trunk/lib/Analysis/PathNumbering.cpp

[Bill Wendling]

On Aug 2, 2011, at 5:55 PM, Chris Lattner wrote:

> On Aug 2, 2011, at 5:30 PM, Bill Wendling wrote:
> 
>> Author: void
>> Date: Tue Aug  2 19:30:19 2011
>> New Revision: 136751
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=136751&view=rev
>> Log:
>> Replace the 'UnwindInst' check with a check for 'ResumeInst', which also exits
>> the function, because the UnwindInst is going away.
> 
> I guess this is safe because no one uses unwind?
> 
There are about four passes which create unwind instructions: ShadowStackGC.cpp, LowerSetJmp.cpp, LowerInvoke.cpp, and UnifyFunctionExitNodes.cpp. I don't think they will interfere with this. But I added the UnwindInst back for now just to be on the safe side...

> -Chris
> 
>> 
>> Modified:
>>   llvm/trunk/lib/Analysis/PathNumbering.cpp
>> 
>> Modified: llvm/trunk/lib/Analysis/PathNumbering.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/PathNumbering.cpp?rev=136751&r1=136750&r2=136751&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Analysis/PathNumbering.cpp (original)
>> +++ llvm/trunk/lib/Analysis/PathNumbering.cpp Tue Aug  2 19:30:19 2011
>> @@ -387,7 +387,7 @@
>> 
>>    TerminatorInst* terminator = currentNode->getBlock()->getTerminator();
>>    if(isa<ReturnInst>(terminator) || isa<UnreachableInst>(terminator)
>> -       || isa<UnwindInst>(terminator))
>> +       || isa<ResumeInst>(terminator))
>>      addEdge(currentNode, getExit(),0);
>> 
>>    currentNode->setColor(BallLarusNode::GRAY);
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>