[llvm-commits] [Patch] Landingpad Instruction

Bill Wendling wendling at apple.com
Tue Aug 2 15:19:31 PDT 2011


On Aug 2, 2011, at 1:32 PM, Chris Lattner wrote:

> On Aug 2, 2011, at 11:36 AM, Bill Wendling wrote:
> 
>> On Aug 2, 2011, at 11:19 AM, Eli Friedman wrote:
>> 
>>> On Tue, Aug 2, 2011 at 10:58 AM, Bill Wendling <wendling at apple.com> wrote:
>>>> Ping?
>>> 
>>> Are you sure the verifier changes are correct given a module which
>>> uses two different different personality functions?  It looks
>>> suspicious.
>>> 
>> Good point. I'll have to clear the PersonalityFn value after it's run on a function.
>> 
>>> Otherwise, it looks okay to me; not sure if you were trying to ping
>>> Chris specifically.
>>> 
>> The ping was for anyone who is qualified to review the patch. I suspect that Chris may have some input and I didn't want to have this fall off his plate. :-)
>> 
>> Thanks for the review!
> 
> Please update the patch after the langref change goes in and I'll take a look, thanks Bill!
> 
Here's an updated version of the landingpad inst patch.

Share and enjoy!
-bw

-------------- next part --------------
A non-text attachment was scrubbed...
Name: landingpadinst.diff
Type: application/octet-stream
Size: 31906 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110802/b9deadeb/attachment.obj>
-------------- next part --------------





More information about the llvm-commits mailing list