[llvm-commits] [llvm] r136485 - /llvm/trunk/utils/TableGen/

David Blaikie dblaikie at gmail.com
Fri Jul 29 13:55:05 PDT 2011


> "const" is most definitely NOT just noise.  It conveys semantics and
> catches errors at compile time.

Can't really catch errors on a type that has no mutation.

& while I agree with you to an extent (in my own code I think I'd
still be inclined to use const on types that are immutable - as I'd
use C++ style casts, std::tie, etc), I think LLVM's code base has some
of these attitudes sufficiently ingrained as to make it unreasonable
to diverge from them at this point. (heck, I helped remove the const
from llvm::Type, even if it didn't exactly match my own personal
coding conventions)

- David




More information about the llvm-commits mailing list