[llvm-commits] [Patch] Removal of Unwind from C-API

[Duncan Sands]

Hi Bill,

> --- include/llvm-c/Core.h	(revision 136325)
> +++ include/llvm-c/Core.h	(working copy)
> @@ -125,7 +125,7 @@
>     LLVMSwitch         = 3,
>     LLVMIndirectBr     = 4,
>     LLVMInvoke         = 5,
> -  LLVMUnwind         = 6,
> +  /* Skipping 6 */
>     LLVMUnreachable    = 7,

rather than removing these, it might be better to comment them out with a
note that Unwind has been removed from LLVM.  That might help people
using the C API to understand what happened.  I'm not sure this is really
a good idea - just a thought.

Ciao, Duncan.

>
>     /* Standard Binary Operators */
> @@ -484,7 +484,6 @@
>           macro(ReturnInst)                   \
>           macro(SwitchInst)                   \
>           macro(UnreachableInst)              \
> -        macro(UnwindInst)                   \
>           macro(ResumeInst)                   \
>       macro(UnaryInstruction)                 \
>         macro(AllocaInst)                     \
> @@ -833,7 +832,6 @@
>                                LLVMValueRef *Args, unsigned NumArgs,
>                                LLVMBasicBlockRef Then, LLVMBasicBlockRef Catch,
>                                const char *Name);
> -LLVMValueRef LLVMBuildUnwind(LLVMBuilderRef);
>   LLVMValueRef LLVMBuildResume(LLVMBuilderRef B, LLVMValueRef Exn);
>   LLVMValueRef LLVMBuildUnreachable(LLVMBuilderRef);