[llvm-commits] [llvm] r136148 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp test/CodeGen/X86/split-vector-bitcast.ll

[Eli Friedman]

Author: efriedma
Date: Tue Jul 26 16:02:58 2011
New Revision: 136148

URL: http://llvm.org/viewvc/llvm-project?rev=136148&view=rev
Log:
Prevent x86-specific DAGCombine from creating nodes with illegal type (which could not be selected).  Fixes a minor isel issue that was breaking the testcase from r136130.


Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
    llvm/trunk/test/CodeGen/X86/split-vector-bitcast.ll

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=136148&r1=136147&r2=136148&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Tue Jul 26 16:02:58 2011
@@ -4520,7 +4520,8 @@
                        LDBase->getPointerInfo(),
                        LDBase->isVolatile(), LDBase->isNonTemporal(),
                        LDBase->getAlignment());
-  } else if (NumElems == 4 && LastLoadedElt == 1) {
+  } else if (NumElems == 4 && LastLoadedElt == 1 &&
+             DAG.getTargetLoweringInfo().isTypeLegal(MVT::v2i64)) {
     SDVTList Tys = DAG.getVTList(MVT::v2i64, MVT::Other);
     SDValue Ops[] = { LDBase->getChain(), LDBase->getBasePtr() };
     SDValue ResNode = DAG.getMemIntrinsicNode(X86ISD::VZEXT_LOAD, DL, Tys,

Modified: llvm/trunk/test/CodeGen/X86/split-vector-bitcast.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/split-vector-bitcast.ll?rev=136148&r1=136147&r2=136148&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/split-vector-bitcast.ll (original)
+++ llvm/trunk/test/CodeGen/X86/split-vector-bitcast.ll Tue Jul 26 16:02:58 2011
@@ -1,7 +1,6 @@
 ; RUN: llc < %s -march=x86 -mattr=-sse2,+sse | grep addps
 
-; XFAIL: *
-; PR10497
+; PR10497 + another isel issue with sse2 disabled
 ; (This is primarily checking that this construct doesn't crash.)
 define void @a(<2 x float>* %a, <2 x i32>* %b) {
   %cc = load <2 x float>* %a