[llvm-commits] [PATCH]: don't use MO_DARWIN_STUB on non-darwin

[Evan Cheng]

Sure, go ahead please.

Evan

On Jul 23, 2011, at 3:05 AM, Roman Divacky wrote:

> ping
> 
> On Tue, Jul 05, 2011 at 02:22:51PM +0200, Roman Divacky wrote:
>> Hi,
>> 
>> In the PPC backend there's this flag MO_DARWIN_STUB that should
>> be set on Darwin < 10.5. The condition to set it is wrong imho.
>> The attached patch fixes it. With the patch I am able to build
>> dynamic libraries that links on FreeBSD (because the flag should
>> not be set there).
>> 
>> In the patch I basically change
>> 
>>        if ((!MacOSX || (MacOSXVersion < 10.5)
>> 
>> to
>> 
>>        if ((MacOSX && (MacOSXVersion < 10.5)
>> 
>> OK to commit? Or is there some hidden magic behind this that I dont see?
>> 
>> roman
> 
> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits