[llvm-commits] [llvm] r135673 - in /llvm/trunk: docs/ examples/BrainF/ include/llvm/ include/llvm/Support/ lib/Analysis/ lib/AsmParser/ lib/Bitcode/Reader/ lib/Target/ARM/ lib/Transforms/IPO/ lib/Transforms/Instrumentation/ lib/Transforms/Scalar/

Jay Foad jay.foad at gmail.com
Fri Jul 22 01:55:05 PDT 2011


>>>> URL: http://llvm.org/viewvc/llvm-project?rev=135673&view=rev
>>>> Log:
>>>> Convert ConstantExpr::getGetElementPtr and
>>>> ConstantExpr::getInBoundsGetElementPtr to use ArrayRef.
>>>>
>>>
>>> You might want to take a look at this MSVC warning:
>>>
>>> 41>InstCombineLoadStoreAlloca.cpp(116): warning C4305: 'argument' :
>>> truncation from 'int' to 'bool'
>>> for:
>>> ConstantExpr::getGetElementPtr(CSrc, Idxs, 2);
>>>
>>> clearly it is not right to pass "2" to a bool param.
>>
>> Thanks! Now fixed. I wish GCC gave me this warning.
>
> ok here another one:
>
> 44>ShadowStackGC.cpp(244): warning C4305: 'argument' : truncation from
> 'int' to 'bool'

Thanks. Now fixed, along with another one in GlobalOpt.cpp. I've
vetted the whole of LLVM and Clang and I can't find any more cases
that I missed.

Jay.



More information about the llvm-commits mailing list