[llvm-commits] [PATCH 07/20] [AVX] Unique BitInit

[David A. Greene]

David Blaikie <dblaikie at gmail.com> writes:

>> Well, there's a scoping issue there.  It seems to me like not polluting
>> the llvm namespace is more beneficial than avoiding some lazy
>> initialization that might happen once and probably not ever because
>> compiler's aren't that smart.  :)
>
> Actually it's the other way - compilers have to do the lazy init

Of course.  Duh.  :)

> But yes, I'd put it in an anonymous namespace (C++ equivalent of a
> c-style file-scoped static, so it doesn't pollute any namespaces) if I
> were doing that.

It pollutes the namespace for the source file, just the same way a
global "static" does.  But in any case, I'll move it out as requested.

                              -Dave