[llvm-commits] [dragonegg] r135472 - /dragonegg/trunk/src/Convert.cpp

[David Blaikie]

>
> >> +  Result = Builder.CreateCall(Intrinsic::getDeclaration(TheModule, Id,
> >> + makeArrayRef(&Ty, 1)),
> >
> > That's ugly. Why doesn't the implicit conversion from Type * to
> > ArrayRef<Type *>  work?
>
> OK. It seems I got it wrong. I used
>
> Builder.CreateCall(Intrinsic::getDeclaration(TheModule, Id, &Ty)
>
> whereas you used
>
> Builder.CreateCall(Intrinsic::getDeclaration(TheModule, Id, Ty)
>                                                             ^^
>
> This makes the difference. Your code compiles for me without any problems.
>

If you're self hosting clang then perhaps Anna's work on "[sema++] clang
should give a fixit for */& mismatch" might be, eventually, able to provide
fixits for this situation. Though I assume this particular scenario won't be
the first that's addressed when adding this feature, owing to the use of
type conversions, etc, necessary to make the FixIt suggestion.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110719/b40b9042/attachment.html>