[llvm-commits] [PATCH] Make Inits FoldingSetNodes

[David A. Greene]

Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

> On Jul 14, 2011, at 3:09 PM, David A. Greene wrote:
>
>> Hmm...Some of our groups here have testing policies that say if valgrind
>> reports a problem, it's a bug.
>
> Heh. Have you told them to avoid grep because it is buggy by their
> definition? ;-)

Um...this isn't a joke.  These are production pieces of software that go
out to customers.  Customers have high quality expectations.

> I don't think deallocating objects would be a significant time sink
> for TableGen, but it needs to be done right. You must take things down
> in the right order, so you don't dereference deleted objects
> accidentally etc. This is probably why you were seeing the pure
> virtual method calls with your patch. Different compilers delete
> globals in different orders.

Perhaps that was the issue but still, that indicates a memory management
problem in TableGen.  Best to root that out ASAP, I think.

                                   -Dave