[llvm-commits] [llvm] r135242 - /llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp

[Evan Cheng]

Good catch. Thanks a lot! I'll check if there similar issues in other targets. 

Evan

On Jul 14, 2011, at 9:16 PM, Chandler Carruth <chandlerc at gmail.com> wrote:

> Author: chandlerc
> Date: Thu Jul 14 23:16:38 2011
> New Revision: 135242
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=135242&view=rev
> Log:
> Remove an unnecessary header from this file. I don't think this header
> was really intended, and it may have been required prior to some of the
> recent refactors. Including it however causes LLVMX86Desc to need
> symbols from LLVMX86CodeGen, forming a dependency cycle. This was masked
> in almost all builds: Clang, and GCC w/ optimizations didn't actually
> emit the symbols!
> 
> Modified:
>    llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
> 
> Modified: llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp?rev=135242&r1=135241&r2=135242&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp (original)
> +++ llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp Thu Jul 14 23:16:38 2011
> @@ -12,7 +12,6 @@
> //===----------------------------------------------------------------------===//
> 
> #include "X86MCAsmInfo.h"
> -#include "X86TargetMachine.h"
> #include "llvm/ADT/Triple.h"
> #include "llvm/MC/MCContext.h"
> #include "llvm/MC/MCExpr.h"
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits