[llvm-commits] [PATCH] Remove Mutating Init Members

David A. Greene greened at obbligato.org
Thu Jul 14 08:07:44 PDT 2011


Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

> On Jul 13, 2011, at 9:37 PM, Nick Lewycky wrote:
>
> The next patch would work fine with an ArrayRef, and in fact it would allow the largish BitsInit::get method to be moved out of line.
>
> This would also be better with the ArrayRef single element constructor:
>
>> +  Init *NewBits[1] = { UI };
>> +  return new BitsInit(NewBits, array_endof(NewBits));

Wasn't aware of ArrayRef.  I'll use it.  I too would like to get
BitsInit::get out of line.

                                  -Dave



More information about the llvm-commits mailing list