[llvm-commits] [llvm] r134907 - /llvm/trunk/utils/TableGen/

[Rotem, Nadav]

Hi Dave, 

I can relate. I've also had to wait a long time for my patches to be reviewed. So, now, when I need someone to review my patches, I just go on IRC and bug people. Usually, even if people are too busy to review my patch, they acknowledge my general solution. (And by "they" I mean Duncan, who helps me all the time). : )


-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of David A. Greene
Sent: Tuesday, July 12, 2011 21:06
To: Jakob Stoklund Olesen
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r134907 - /llvm/trunk/utils/TableGen/

Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

>> If you're not getting a response, please ping the patch like everyone else.  Ignoring policy is not the solution.
>
>
> David's request for review:	Fri  9:41 AM PDT
> My reply to David:		Mon 10:11 AM PDT
> David's committing r134907:	Mon 11:25 AM PDT

My timeline was off.  I apologize.  But it still took a very long time
to get any sort of response.  I have waited days in the past.  That
simply won't work in a fast-moving project like LLVM.  I had to
constantly update this patch over the period between the review request
and the actual commit due to changes in LLVM.

Can we institute some kind of deadline for review request reponses?
That way at least the submitter won't be stuck forever.

                                -Dave
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.