[llvm-commits] [llvm] r134907 - /llvm/trunk/utils/TableGen/

[Jakob Stoklund Olesen]

On Jul 12, 2011, at 8:53 AM, Chris Lattner wrote:

> 
> On Jul 12, 2011, at 7:48 AM, David A. Greene wrote:
> 
>> Chris Lattner <clattner at apple.com> writes:
>> 
>>> This is a major change in an area that you don't own.  This should be
>>> reviewed before you commit it.
>> 
>> I requested a review five days ago.  I cannot wait a week for every
>> change I need to make for AVX.  It will never get done.  I am very happy
>> to have things reviewed but reviewers need to be prompt.
> 
> If you're not getting a response, please ping the patch like everyone else.  Ignoring policy is not the solution.


David's request for review:	Fri  9:41 AM PDT
My reply to David:		Mon 10:11 AM PDT
David's committing r134907:	Mon 11:25 AM PDT

Pinging a patch after waiting less than 10 normal working hours would be rather obnoxious. We should encourage developers to have a bit more patience than that. Many reviewers are quite busy.

/jakob