[llvm-commits] [llvm] r134888 - in /llvm/trunk: include/llvm/ include/llvm/Support/ lib/AsmParser/ lib/Bitcode/Reader/ lib/CodeGen/ lib/Target/Blackfin/ lib/Target/MBlaze/ lib/Transforms/IPO/ lib/Transforms/InstCombine/ lib/Transforms/Instrumenta

[Jay Foad]

Reinstated and (hopefully) fixed in r134982. I now understand why
C++0x has "override"!

Thanks,
Jay.

On 12 July 2011 08:17, Bill Wendling <wendling at apple.com> wrote:
> No worries. llvm-gcc doesn't get a lot of attention these days. :-) Thanks for looking into it!
>
> -bw
>
> On Jul 11, 2011, at 11:29 PM, Jay Foad wrote:
>
>> Thanks. I'll look into it today. Sorry for the breakage.
>>
>> Jay.
>>
>> On 12 July 2011 02:18, Bill Wendling <wendling at apple.com> wrote:
>>> Hi Jay,
>>>
>>> I had to revert this and your related patches. It was causing llvm-gcc to fail to compile on Darwin (possibly other machines). It was an assert:
>>>
>>> Assertion failed: (castIsValid(op, S, Ty) && "Invalid cast!"), function Create, file ...
>>>
>>> -bw
>>>
>>> On Jul 11, 2011, at 12:56 AM, Jay Foad wrote:
>>>
>>>> Author: foad
>>>> Date: Mon Jul 11 02:56:41 2011
>>>> New Revision: 134888
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=134888&view=rev
>>>> Log:
>>>> De-constify Types in FunctionType::get().
>>>>
>>>> Modified:
>>>>    llvm/trunk/include/llvm/DerivedTypes.h
>>>>    llvm/trunk/include/llvm/Intrinsics.h
>>>>    llvm/trunk/include/llvm/Support/TypeBuilder.h
>>>>    llvm/trunk/lib/AsmParser/LLParser.cpp
>>>>    llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
>>>>    llvm/trunk/lib/CodeGen/DwarfEHPrepare.cpp
>>>>    llvm/trunk/lib/CodeGen/IntrinsicLowering.cpp
>>>>    llvm/trunk/lib/Target/Blackfin/BlackfinIntrinsicInfo.cpp
>>>>    llvm/trunk/lib/Target/MBlaze/MBlazeIntrinsicInfo.cpp
>>>>    llvm/trunk/lib/Transforms/IPO/ArgumentPromotion.cpp
>>>>    llvm/trunk/lib/Transforms/IPO/DeadArgumentElimination.cpp
>>>>    llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
>>>>    llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp
>>>>    llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp
>>>>    llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp
>>>>    llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp
>>>>    llvm/trunk/lib/Transforms/Scalar/ObjCARC.cpp
>>>>    llvm/trunk/lib/Transforms/Scalar/SimplifyLibCalls.cpp
>>>>    llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp
>>>>    llvm/trunk/lib/Transforms/Utils/CodeExtractor.cpp
>>>>    llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp
>>>>    llvm/trunk/lib/VMCore/Core.cpp
>>>>    llvm/trunk/lib/VMCore/Function.cpp
>>>>    llvm/trunk/lib/VMCore/IRBuilder.cpp
>>>>    llvm/trunk/lib/VMCore/Module.cpp
>>>>    llvm/trunk/lib/VMCore/Type.cpp
>>>>    llvm/trunk/unittests/Analysis/ScalarEvolutionTest.cpp
>>>>    llvm/trunk/unittests/ExecutionEngine/JIT/JITMemoryManagerTest.cpp
>>>>    llvm/trunk/unittests/ExecutionEngine/JIT/JITTest.cpp
>>>>    llvm/trunk/unittests/Support/TypeBuilderTest.cpp
>>>>    llvm/trunk/unittests/VMCore/PassManagerTest.cpp