[llvm-commits] [PATCH] Make TableGen Inits FoldingSetNodes
David A. Greene
greened at obbligato.org
Mon Jul 11 14:25:53 PDT 2011
Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:
>> I can't. It's needed to maintain const-correctness. LLVM won't build
>> without it.
>
> Sure you can.
How? get() should return a const <foo>Init *. As soon as you do that,
it has to be const everywhere.
Otherwise there is a big risk of getting the patch wrong. Having
"const" there caught a lot of bugs as I developed this patch.
> Let's discuss after you revert your patches.
I've committed the name change from Create() to get(). What else
needs to be done?
-Dave
More information about the llvm-commits
mailing list