[llvm-commits] [llvm] r134795 - in /llvm/trunk: include/llvm/MC/ include/llvm/Target/ lib/CodeGen/AsmPrinter/ lib/MC/ lib/MC/MCDisassembler/ lib/Target/ lib/Target/ARM/AsmParser/ lib/Target/ARM/MCTargetDesc/ lib/Target/Alpha/ lib/Target/Blackfin/ lib/Target/CBackend/ lib/Target/CellSPU/ lib/Target/CppBackend/ lib/Target/MBlaze/ lib/Target/MBlaze/AsmParser/ lib/Target/MSP430/ lib/Target/Mips/ lib/Target/PTX/ lib/Target/PowerPC/ lib/Target/Sparc/ lib/Target/SystemZ/ lib/Target/X86/AsmParser/ lib/Target/X86/MCTargetDesc/ ...

[Joerg Sonnenberger]

On Sat, Jul 09, 2011 at 05:47:47AM -0000, Evan Cheng wrote:
> Log:
> Change createAsmParser to take a MCSubtargetInfo instead of triple,
> CPU, and feature string. Parsing some asm directives can change
> subtarget state (e.g. .code 16) and it must be reflected in other
> modules (e.g. MCCodeEmitter). That is, the MCSubtargetInfo instance
> must be shared.

Are you sure that e.g. ".code XX" should effect anything outside the asm
parser? I think for inline assembly, it should create a warning if the
mode at the start and the mode at the end are different, but otherwise
it seems like a typical setting that should be constrained to the
assembler block.

Joerg