[llvm-commits] [llvm] r134577 - in /llvm/trunk: include/llvm/Target/TargetAsmInfo.h include/llvm/Target/TargetFrameLowering.h lib/MC/MCDwarf.cpp lib/Target/TargetAsmInfo.cpp lib/Target/X86/X86FrameLowering.cpp lib/Target/X86/X86FrameLowering.h

[Chris Lattner]

On Jul 6, 2011, at 5:54 PM, Bill Wendling wrote:

> Author: void
> Date: Wed Jul  6 19:54:13 2011
> New Revision: 134577
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=134577&view=rev
> Log:
> Add a target hook to encode the compact unwind information.

Ok.

> +++ llvm/trunk/include/llvm/Target/TargetFrameLowering.h Wed Jul  6 19:54:13 2011
> @@ -14,6 +14,7 @@
> #ifndef LLVM_TARGET_TARGETFRAMELOWERING_H
> #define LLVM_TARGET_TARGETFRAMELOWERING_H
> 
> +#include "llvm/MC/MCDwarf.h"
> #include "llvm/CodeGen/MachineBasicBlock.h"

Please forward declare MCCFIInstruction.

> @@ -189,6 +190,14 @@
>   ///
>   virtual void processFunctionBeforeFrameFinalized(MachineFunction &MF) const {
>   }
> +
> +  /// getCompactUnwindEncoding - Get the compact unwind encoding for the
> +  /// function. Return 0 if the compact unwind isn't available.
> +  virtual uint32_t getCompactUnwindEncoding(const std::vector<MCCFIInstruction>&,
> +                                            int /*DataAlignmentFactor*/,
> +                                            bool /*IsEH*/) const {

Please put names on these arguments like other stuff in this file.  Instead of taking a const vector, should this take an ArrayRef?

-Chris