[llvm-commits] [PATCH]: don't use MO_DARWIN_STUB on non-darwin

Roman Divacky rdivacky at freebsd.org
Tue Jul 5 05:22:51 PDT 2011


Hi,

In the PPC backend there's this flag MO_DARWIN_STUB that should
be set on Darwin < 10.5. The condition to set it is wrong imho.
The attached patch fixes it. With the patch I am able to build
dynamic libraries that links on FreeBSD (because the flag should
not be set there).

In the patch I basically change

        if ((!MacOSX || (MacOSXVersion < 10.5)

to

        if ((MacOSX && (MacOSXVersion < 10.5)

OK to commit? Or is there some hidden magic behind this that I dont see?

roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ppc-darwin.patch
Type: text/x-diff
Size: 1164 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110705/969659e8/attachment.patch>


More information about the llvm-commits mailing list