[llvm-commits] [llvm] r134198 - /llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

[Jim Grosbach]

On Jun 30, 2011, at 3:17 PM, Eric Christopher wrote:

> Author: echristo
> Date: Thu Jun 30 17:17:01 2011
> New Revision: 134198
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=134198&view=rev
> Log:
> Add a convenience typedef for std::pair<unsigned, const TargetRegisterClass*>.
> 
> No functional change.
> 
> Part of rdar://9119939
> 
> Modified:
>    llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
> 
> Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=134198&r1=134197&r2=134198&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Thu Jun 30 17:17:01 2011
> @@ -7527,7 +7527,8 @@
>   return weight;
> }
> 
> -std::pair<unsigned, const TargetRegisterClass*>
> +typedef std::pair<unsigned, const TargetRegisterClass*> Pair;
> +Pair

<nit>Mind giving the typedef a more informational name?</nit>

> ARMTargetLowering::getRegForInlineAsmConstraint(const std::string &Constraint,
>                                                 EVT VT) const {
>   if (Constraint.size() == 1) {
> @@ -7535,18 +7536,18 @@
>     switch (Constraint[0]) {
>     case 'l':
>       if (Subtarget->isThumb())
> -        return std::make_pair(0U, ARM::tGPRRegisterClass);
> +        return Pair(0U, ARM::tGPRRegisterClass);
>       else
> -        return std::make_pair(0U, ARM::GPRRegisterClass);
> +        return Pair(0U, ARM::GPRRegisterClass);
>     case 'r':
> -      return std::make_pair(0U, ARM::GPRRegisterClass);
> +      return Pair(0U, ARM::GPRRegisterClass);
>     case 'w':
>       if (VT == MVT::f32)
> -        return std::make_pair(0U, ARM::SPRRegisterClass);
> +        return Pair(0U, ARM::SPRRegisterClass);
>       if (VT.getSizeInBits() == 64)
> -        return std::make_pair(0U, ARM::DPRRegisterClass);
> +        return Pair(0U, ARM::DPRRegisterClass);
>       if (VT.getSizeInBits() == 128)
> -        return std::make_pair(0U, ARM::QPRRegisterClass);
> +        return Pair(0U, ARM::QPRRegisterClass);
>       break;
>     }
>   }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits