[llvm-commits] [patch] Fix deprecation warning in lit on OS X

Andrew Trick atrick at apple.com
Wed Jun 29 16:46:48 PDT 2011


On Jun 29, 2011, at 11:57 AM, Jordy Rose wrote:
> I usually hang out on the Clang side of things, but I've noticed that the lit tests have a deprecation warning about 'popen2' that comes up on OS X. The attached patch replaces the use of 'popen2' with 'subprocess.Popen'.
> 
> Jordy

Looks good.

FWIW, the more common idiom seems to be "out,_ = p.communicate()"

-Andy



More information about the llvm-commits mailing list