[llvm-commits] [llvm] r133708 - in /llvm/trunk: include/llvm/ include/llvm/Support/ lib/MC/ lib/Target/CppBackend/ lib/Transforms/Scalar/ lib/Transforms/Utils/ lib/VMCore/

[Cameron Zwarich]

On 2011-06-26, at 4:57 PM, Francois Pichet wrote:

> On Thu, Jun 23, 2011 at 5:09 AM, Jay Foad <jay.foad at gmail.com> wrote:
>> Author: foad
>> Date: Thu Jun 23 04:09:15 2011
>> New Revision: 133708
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=133708&view=rev
>> Log:
>> Reinstate r133513 (reverted in r133700) with an additional fix for a
>> -Wshorten-64-to-32 warning in Instructions.h.
> 
> Hi Jay, This commit creates a very weird problem on MSVC where clang
> test /CodeGen/vla.c stalls in release mode. (but not in debug).
> 
> I suspect a subtle memory corruption issue that doesn't show up on the
> various unixes system because we get lucky. Windows .exe are generally
> easier to crash if there is a memory corruption issue.
> 
> Thank to chapuni for identifying this commit as the source of the problem.

The last time we had a problem like this with MSVC it was due to a miscompile. Someone should probably check what is going on here before trying to work around it or revert the patch.

Cameron