[llvm-commits] [llvm] r133832 - /llvm/trunk/utils/TableGen/NeonEmitter.cpp

[Bob Wilson]

Author: bwilson
Date: Fri Jun 24 17:13:17 2011
New Revision: 133832

URL: http://llvm.org/viewvc/llvm-project?rev=133832&view=rev
Log:
Revert "Shorten some ARM builtin names by removing unnecessary "neon" prefix."
Sorry, this was a bad idea.  Within clang these builtins are in a separate
"ARM" namespace, but the actual builtin names should clearly distinguish that
they are target specific.

Modified:
    llvm/trunk/utils/TableGen/NeonEmitter.cpp

Modified: llvm/trunk/utils/TableGen/NeonEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/NeonEmitter.cpp?rev=133832&r1=133831&r2=133832&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/NeonEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/NeonEmitter.cpp Fri Jun 24 17:13:17 2011
@@ -889,7 +889,7 @@
   return ret;
 }
 
-// Generate the definition for this intrinsic.
+// Generate the definition for this intrinsic, e.g. __builtin_neon_cls(a)
 static std::string GenBuiltin(const std::string &name, const std::string &proto,
                               StringRef typestr, ClassKind ck) {
   std::string s;
@@ -923,7 +923,7 @@
 
   bool splat = proto.find('a') != std::string::npos;
 
-  s += "__builtin_";
+  s += "__builtin_neon_";
   if (splat) {
     // Call the non-splat builtin: chop off the "_n" suffix from the name.
     std::string vname(name, 0, name.size()-2);
@@ -1009,7 +1009,7 @@
 static std::string GenBuiltinDef(const std::string &name,
                                  const std::string &proto,
                                  StringRef typestr, ClassKind ck) {
-  std::string s("BUILTIN(__builtin_");
+  std::string s("BUILTIN(__builtin_neon_");
 
   // If all types are the same size, bitcasting the args will take care
   // of arg checking.  The actual signedness etc. will be taken care of with
@@ -1354,11 +1354,11 @@
       }
     }
     if (mask)
-      OS << "case ARM::BI__builtin_"
+      OS << "case ARM::BI__builtin_neon_"
          << MangleName(name, TypeVec[si], ClassB)
          << ": mask = " << "0x" << utohexstr(mask) << "; break;\n";
     if (qmask)
-      OS << "case ARM::BI__builtin_"
+      OS << "case ARM::BI__builtin_neon_"
          << MangleName(name, TypeVec[qi], ClassB)
          << ": mask = " << "0x" << utohexstr(qmask) << "; break;\n";
   }
@@ -1446,7 +1446,7 @@
           case 'i': ie = ii + 1; break;
         }
       }
-      OS << "case ARM::BI__builtin_" << MangleName(name, TypeVec[ti], ck)
+      OS << "case ARM::BI__builtin_neon_" << MangleName(name, TypeVec[ti], ck)
          << ": i = " << immidx << "; " << rangestr << "; break;\n";
     }
   }