[llvm-commits] [llvm] r133513 - in /llvm/trunk: include/llvm/ include/llvm/Support/ lib/Target/CppBackend/ lib/Transforms/Scalar/ lib/Transforms/Utils/ lib/VMCore/

[Eric Christopher]

On Jun 23, 2011, at 2:17 AM, Jay Foad wrote:

> On 23 June 2011 07:31, Eric Christopher <echristo at apple.com> wrote:
>> 
>> On Jun 22, 2011, at 11:24 AM, Eric Christopher wrote:
>> 
>>> 
>>> On Jun 21, 2011, at 3:33 AM, Jay Foad wrote:
>>> 
>>>> Author: foad
>>>> Date: Tue Jun 21 05:33:19 2011
>>>> New Revision: 133513
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=133513&view=rev
>>>> Log:
>>>> Reinstate r133435 and r133449 (reverted in r133499) now that the clang
>>>> self-hosted build failure has been fixed (r133512).
>>>> 
>>> 
>>> This is causing some additional warnings:
>>> 
>>> /Developer/usr/local/include/llvm/Instructions.h: In member function 'llvm::BasicBlock* llvm::PHINode::getIncomingBlock(const llvm::Use&) const':
>>> /Developer/usr/local/include/llvm/Instructions.h:1909: warning: implicit conversion shortens 64-bit value into a 32-bit value
> 
> I've fixed this one...

Thanks :)

> 
>>> To duplicate just turn on conversion warnings, in particular with llvm-gcc -Wshorten-64-to-32, in a file that includes Instructions.h.
> 
> (I can't tell if there are any others, because if I build with clang
> -Wshorten-64-to-32 I get loads of unrelated warnings)
> 

Yeah. It's near the end of a very long list of things for me. :(

>> I've gone ahead and reverted your patch in r133700 for the time being, should be an easy reapply after you fix the new header warnings :)
> 
> ... and re-reinstated my patch in r133708.

Thank you very much :)

-eric