[llvm-commits] patch: fix emission of npot vectors which need trailing padding

[Nick Lewycky]

On 22 June 2011 01:26, Renato Golin <renato.golin at arm.com> wrote:

> On 22 June 2011 00:19, Nick Lewycky <nlewycky at google.com> wrote:
> > Hi Renato! Sorry, but I don't understand your reply at all.
>
> I think you did, and answered my question at the same time. ;)
>
>
> > There's nothing ARM-specific about this change, which is why it belongs
> in
> > generic CodeGen and shouldn't be in the ARMAsmPrinter. It just so happens
> > that <3 x float> on ARM provides a counter-example that would require
> this
> > padding or trigger this assertion.
>
> I was fooled by your comment on ARM's vector size and thought your
> patch was in the wrong place. As you say (and Eli has shown), this is
> not platform specific, so the patch is good.
>
> Sorry about the confusion.
>

No problem, thanks for the review!

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110622/bd0b7b45/attachment.html>