[llvm-commits] [llvm] r133412 - in /llvm/trunk: include/llvm/Constants.h lib/Analysis/ConstantFolding.cpp lib/AsmParser/LLParser.cpp lib/Bitcode/Reader/BitcodeReader.cpp lib/CodeGen/ShadowStackGC.cpp lib/Transforms/IPO/GlobalOpt.cpp lib/Transform

[John McCall]

On Jun 21, 2011, at 11:35 AM, Jay Foad wrote:

>> Mostly I'm just skeptical of having an O(n) implicit conversion, but it also seems
>> odd to privilege std::vector here.
> 
> I'm probably biased by what I'm trying to do now, but I'm thinking of
> ArrayRef as a more flexible replacement for "const vector &". (More
> flexible since it doesn't have to refer to a *vector*, it could refer
> to a C array or other things.) Since "const vector &" implicitly
> converts to vector, I don't see the problem with ArrayRef doing the
> same.

Well, I'm worried it'll cause trouble down the road, but I guess it's fine for now.

John.