[llvm-commits] [llvm] r133435 - in /llvm/trunk: include/llvm/ include/llvm/Support/ lib/Target/CppBackend/ lib/Transforms/Scalar/ lib/Transforms/Utils/ lib/VMCore/

Jay Foad jay.foad at gmail.com
Mon Jun 20 10:52:53 PDT 2011


On 20 June 2011 17:03, Frits van Bommel <fvbommel at gmail.com> wrote:
>>  void PHINode::growOperands() {
>>   unsigned e = getNumOperands();
>> -  // Multiply by 1.5 and round down so the result is still even.
>> -  unsigned NumOps = e + e / 4 * 2;
>> +  unsigned NumOps = e + e / 2;
>>   if (NumOps < 4) NumOps = 4;      // 4 op PHI nodes are VERY common.
>
> Wouldn't it now be 2-op PHI nodes that are "VERY common"?
> (since 2 of the ops used to be basic blocks)

Well spotted! I've fixed it now.

Jay.




More information about the llvm-commits mailing list