[llvm-commits] [llvm] r133314 - /llvm/trunk/lib/MC/MCAsmStreamer.cpp

[Bill Wendling]

On Jun 18, 2011, at 2:19 AM, Chandler Carruth wrote:

> On Fri, Jun 17, 2011 at 4:42 PM, Bill Wendling <isanbard at gmail.com> wrote:
> Author: void
> Date: Fri Jun 17 18:42:01 2011
> New Revision: 133314
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=133314&view=rev
> Log:
> Remove false assertion.
> 
> This appears to do more than that? Was this intended:
> 
It should have been removing the assertion and then enabling the pass. Sorry for the confusion.

> -#if 0
> 
> ? Test case or something else for the newly enabled code? Just didn't want this to be an accidental commit that didn't get noticed.

It's not. :-) Thanks for checking. Chris mentioned that this might be better served being placed in the ASM comments that are emitted from llc. I like the ability to use this via llvm-mc on an existing .s file, but his point that the utility isn't enough to justify the extra complexity is well taken. So I'm going to have to rework this a bit.

We don't normally have testcases for ASM comments, but I can try to come up with some if you feel strongly about them. :)

-bw