[llvm-commits] Retail warnings in Mips lowering code

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Wed Jun 15 17:47:55 PDT 2011


On Wed, Jun 8, 2011 at 10:42 PM, David Blaikie <dblaikie at gmail.com> wrote:
> There's a couple of variables that are only used in asserts in the MIPS
> lowering code (lib/Target/Mips/MipsISelLowering.cpp) - this causes warnings
> in retail builds.
> I've fixed both instances by rolling the relevant expression (they don't
> appear to have any side effects) into the assert call & I added a comment in
> the second case since it seemed like the name of the variable gave some
> context/semantic information that wasn't necessarily entirely obvious from
> the expression itself.

Commited only the first part in r133118 cause StackAlignment is used afterwards.


-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc



More information about the llvm-commits mailing list