[llvm-commits] [llvm] r133050 - in /llvm/trunk/lib: AsmParser/LLLexer.cpp VMCore/AsmWriter.cpp

[Nick Lewycky]

On 15 June 2011 10:23, Dan Gohman <gohman at apple.com> wrote:

>
> On Jun 14, 2011, at 11:37 PM, Nick Lewycky wrote:
>
> > Author: nicholas
> > Date: Wed Jun 15 01:37:58 2011
> > New Revision: 133050
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=133050&view=rev
> > Log:
> > Teach the .ll parser to handle named metadata with non-simple names.
> > Unfortunately we can't follow what the rest of the language does
> (wrapping it
> > in double-quotes) because that would cause an ambiguity with metadata
> strings,
> > so instead we escape any unusual characters with \xx escaping.
>
> Named metadata names can never appear in the same context as metadata
> strings, so so it actually wouldn't be strictly ambiguous.  I don't know if
> that's
> worth pursuing though.  May I ask what you're doing that needs
> non-simply-named named metadata?
>

http://android-developers.blogspot.com/2011/02/introducing-renderscript.html

The renderscript developers decided to prefix their metadata with # signs,
which they didn't have to, but now that the product is shipping I don't
think that will be changing.

Either way, please add a testcase.
>

Thanks for the reminder, I'll do that late tonight / early tomorrow.

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110615/7b0598a6/attachment.html>