[llvm-commits] patch: use movd for 32-bits and movq for 64-bits consistently

Nick Lewycky nlewycky at google.com
Mon Jun 13 21:29:34 PDT 2011


I don't understand why we had an alternative for movq/movd. As far as I can
tell on both x86-32 and x86-64 we're supposed to be using movq for
xmm<->64-bit memory or register and movd for xmm<->32-bit memory or
register. This patch removes the alternatives from the .td file and updates
the test.

It seems likely to me that I'm missing something important here, but
everything seems to just work for me with this patch applied, both in x86-64
and x86-32 builds.

This is intended to fix PR10134 but for reference PR2677 and PR2108 are also
about movd and movq so you may want to look at them too. I'd appreciate code
review, in particular from Evan and Anton who've commented on bugs around
this issue in the past.

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110613/dd9760cc/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr10134.patch
Type: text/x-patch
Size: 7610 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110613/dd9760cc/attachment.bin>


More information about the llvm-commits mailing list