[llvm-commits] [llvm] r132790 - /llvm/trunk/lib/MC/ELFObjectWriter.cpp

[Rafael Avila de Espindola]

On 11-06-09 03:13 PM, Jason W Kim wrote:
> Author: jasonwkim
> Date: Thu Jun  9 14:13:45 2011
> New Revision: 132790
>
> URL: http://llvm.org/viewvc/llvm-project?rev=132790&view=rev
> Log:
> Remove an uneeded switch - Turns out reloc results are identical w/o the switch. (face+palm)

Thanks!

>
> Modified:
>      llvm/trunk/lib/MC/ELFObjectWriter.cpp
>
> Modified: llvm/trunk/lib/MC/ELFObjectWriter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/ELFObjectWriter.cpp?rev=132790&r1=132789&r2=132790&view=diff
> ==============================================================================
> --- llvm/trunk/lib/MC/ELFObjectWriter.cpp (original)
> +++ llvm/trunk/lib/MC/ELFObjectWriter.cpp Thu Jun  9 14:13:45 2011
> @@ -37,17 +37,6 @@
>   #undef  DEBUG_TYPE
>   #define DEBUG_TYPE "reloc-info"
>
> -// FIXME: This switch must be removed. Since GNU as does not
> -// need a command line switch for doing its wierd thing with PIC,
> -// LLVM should not need it either.
> -// --
> -// Emulate the wierd behavior of GNU-as for relocation types
> -namespace llvm {
> -cl::opt<bool>
> -ForceARMElfPIC("arm-elf-force-pic", cl::Hidden, cl::init(false),
> -               cl::desc("Force ELF emitter to emit PIC style relocations"));
> -}
> -
>   bool ELFObjectWriter::isFixupKindPCRel(const MCAssembler&Asm, unsigned Kind) {
>     const MCFixupKindInfo&FKI =
>       Asm.getBackend().getFixupKindInfo((MCFixupKind) Kind);
> @@ -1321,7 +1310,7 @@
>           <<  Symbol.isVariable()<<  "/"<<  Symbol.isTemporary()
>           <<  " Counts:"<<  PCRelCount<<  "/"<<  NonPCRelCount<<  "\n");
>
> -  if (IsPCRel || ForceARMElfPIC) { ++PCRelCount;
> +  if (IsPCRel) { ++PCRelCount;
>       switch (RelocType) {
>       default:
>         // Most relocation types are emitted as explicit symbols
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits