[llvm-commits] [llvm] r132676 - in /llvm/trunk: lib/CodeGen/SelectionDAG/FastISel.cpp test/CodeGen/X86/fast-isel-agg-constant.ll

Jim Grosbach grosbach at apple.com
Thu Jun 9 11:22:41 PDT 2011


On Jun 9, 2011, at 1:08 AM, Roman Divacky wrote:

> On Wed, Jun 08, 2011 at 11:08:36PM -0700, Eric Christopher wrote:
>> 
>> On Jun 6, 2011, at 8:38 AM, Roman Divacky wrote:
>> 
>>> OK to commit? Or is there a better way to distinguish those two
>>> asm dialects?
>> 
>> Maybe check the Subtarget instead?
> 
> Where do I get it in MCExpr?

If at all possible, we want to avoid the Subtarget in MC layer operations. There are a few places it's done, but it's a layering violation that we're trying very hard to avoid. Long term, we want to refactor the target machine to allow us to decouple it from MC.

For purposes of something like this, you would theoretically just use the target triple. That is, if the triple specifies the target is Darwin (or not), behave accordingly. I don't think the triple is explicitly threaded through MC, though, so other than conceptually, I don't think that helps you much.

CCing Daniel. He may know some sneaky ways to get the info.

-Jim



More information about the llvm-commits mailing list