[llvm-commits] patch: refactor the asmparser a little

Nick Lewycky nlewycky at google.com
Thu Jun 2 17:18:59 PDT 2011


The attached patch refactors the asm parsers' parsing of strings into a
ReadString method and parsing of LocalVarName or GlobalVarName into
ReadName(). No functionality change intended.

I'm asking for review because the parser doesn't already have helper
functions like these, and I wanted to check whether the error-reporting
style (inconsistent between the two) is okay to commit or if anyone has
suggestions.

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110602/76a936fc/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asmparser-refactor.patch
Type: text/x-patch
Size: 4105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110602/76a936fc/attachment.bin>


More information about the llvm-commits mailing list