[llvm-commits] [llvm] r132164 - /llvm/trunk/lib/Transforms/Scalar/CodeGenPrepare.cpp

[Chandler Carruth]

On Thu, May 26, 2011 at 4:16 PM, Devang Patel <dpatel at apple.com> wrote:

> +      if (!VI->isTerminator() &&
> +          DVI->getParent() != VI->getParent() || DT->dominates(DVI, VI)) {
>

This will ignore (!VI->isTerminator()) if DT->dominates(DVI, VI returns
true. ;] We have a warning on this construct in Clang (based on GCC's
warning). I added parentheses in r132165 to more closely match the intent
your commit log conveyed, but let me know if that isn't correct.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110526/c23bf487/attachment.html>