[llvm-commits] [cfe-commits] [PATCH] ARM strexd and ldrexd intrinsics

[Evan Cheng]

On May 25, 2011, at 6:09 PM, Bruno Cardoso Lopes wrote:

>> 1. Please rename SelectAddrMode7. There is no such addressing mode. We used 1, 2, ..., 6 because that's what earlier ARM doc used, but we really should rename them.
> 
> Ok
> 
>> 2. Another solution for the register pair issue is to assign them fixed physical registers at isel time. The good thing about it is it eliminate the complexity in ARMLoadStoreOpt.
> 
> I would be fine with this too. The only problem is that I would have
> to manually select the strexd instead of using a simple pattern for
> it, but it's always a tradeoff anyway. Let me know which approach is
> preferred then.

I would prefer the isel approach and avoid the load / store optimization complexity.

Thanks,

Evan

> 
> 
> -- 
> Bruno Cardoso Lopes
> http://www.brunocardoso.cc