[llvm-commits] [llvm] r131824 - /llvm/trunk/tools/opt/opt.cpp

[Cameron Zwarich]

On May 21, 2011, at 11:49 PM, Chris Lattner wrote:

> On May 21, 2011, at 11:28 PM, Cameron Zwarich wrote:
> 
>> On May 21, 2011, at 11:27 PM, Chris Lattner wrote:
>> 
>>> On May 21, 2011, at 11:02 PM, Cameron Zwarich wrote:
>>> 
>>>> This changed the opt pass order by removing the global passes that run first:
>>>> 
>>>> Pass Arguments:  -targetdata -no-aa -tbaa -basicaa -simplifycfg -domtree -scalarrepl -early-cse
>>>> Target Data Layout
>>>> No Alias Analysis (always returns 'may' alias)
>>>> Type-Based Alias Analysis
>>>> Basic Alias Analysis (stateless AA impl)
>>>> ModulePass Manager
>>>> FunctionPass Manager
>>>>   Simplify the CFG
>>>>   Dominator Tree Construction
>>>>   Scalar Replacement of Aggregates (DT)
>>>>   Early CSE
>>>> 
>>>> In the future, it would be a good idea to compare -debug-pass=Structure output when making changes that are supposed to preserve existing behavior. It would also be good to check that clang still includes these passes.
>>> 
>>> Hi Cameron,
>>> 
>>> What behavior are you saying that I'm changing here?  "opt" has a bunch of different codepaths.
>> 
>> opt -std-compile-opts -debug-pass=Structure <file>
> 
> -std-compile-opts is the same before and after my patch.  You're right though that -O1/2/3 stopped printing this stuff (though the passes are still being run).  Fixed in r131843.  Thanks,

Oh, good thing it was just a printing issue. Now the bots won't all get random codegen changes tonight. Thanks!

Cameron