[llvm-commits] [llvm] r131836 - /llvm/trunk/lib/MC/MCDisassembler/Disassembler.cpp

[Chris Lattner]

Author: lattner
Date: Sat May 21 23:52:24 2011
New Revision: 131836

URL: http://llvm.org/viewvc/llvm-project?rev=131836&view=rev
Log:
tidy some things up.

Modified:
    llvm/trunk/lib/MC/MCDisassembler/Disassembler.cpp

Modified: llvm/trunk/lib/MC/MCDisassembler/Disassembler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCDisassembler/Disassembler.cpp?rev=131836&r1=131835&r2=131836&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCDisassembler/Disassembler.cpp (original)
+++ llvm/trunk/lib/MC/MCDisassembler/Disassembler.cpp Sat May 21 23:52:24 2011
@@ -6,11 +6,10 @@
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
+
 #include "Disassembler.h"
-#include <stdio.h>
 #include "llvm-c/Disassembler.h"
 
-#include <string>
 #include "llvm/MC/MCAsmInfo.h"
 #include "llvm/MC/MCDisassembler.h"
 #include "llvm/MC/MCInst.h"
@@ -27,17 +26,12 @@
 } // namespace llvm
 using namespace llvm;
 
-#ifdef __cplusplus
-extern "C" {
-#endif // __cplusplus
-
-//
 // LLVMCreateDisasm() creates a disassembler for the TripleName.  Symbolic
 // disassembly is supported by passing a block of information in the DisInfo
-// parameter and specifing the TagType and call back functions as described in
+// parameter and specifying the TagType and callback functions as described in
 // the header llvm-c/Disassembler.h .  The pointer to the block and the 
-// functions can all be passed as NULL.  If successful this returns a
-// disassembler context if not it returns NULL.
+// functions can all be passed as NULL.  If successful, this returns a
+// disassembler context.  If not, it returns NULL.
 //
 LLVMDisasmContextRef LLVMCreateDisasm(const char *TripleName, void *DisInfo,
                                       int TagType, LLVMOpInfoCallback GetOpInfo,
@@ -108,7 +102,6 @@
 // The memory object created by LLVMDisasmInstruction().
 //
 class DisasmMemoryObject : public MemoryObject {
-private:
   uint8_t *Bytes;
   uint64_t Size;
   uint64_t BasePC;
@@ -126,7 +119,7 @@
     return 0;
   }
 };
-} // namespace
+} // end anonymous namespace
 
 //
 // LLVMDisasmInstruction() disassembles a single instruction using the
@@ -159,13 +152,10 @@
   IP->printInst(&Inst, OS);
   OS.flush();
 
+  assert(OutStringSize != 0 && "Output buffer cannot be zero size");
   size_t OutputSize = std::min(OutStringSize-1, InsnStr.size());
   std::memcpy(OutString, InsnStr.data(), OutputSize);
   OutString[OutputSize] = '\0'; // Terminate string.
 
   return Size;
 }
-
-#ifdef __cplusplus
-}
-#endif // __cplusplus